Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version redirects to current version #1162

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Add version redirects to current version #1162

merged 3 commits into from
Oct 4, 2023

Conversation

Dr-Electron
Copy link
Collaborator

@Dr-Electron Dr-Electron commented Sep 7, 2023 •
edited
Loading

Description of change

This PR adds version redirects so that the current version is not only accessible from /<project>/** but also from /<project>/<current-version>/**

Links to any relevant issues

Fixes #1086.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

@Dr-Electron
Copy link
Collaborator Author

/create-preview

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

This pull request has been deployed to Vercel.

Latest commit:

✅ Preview: https://iota-wiki-98xis31i6-iota1.vercel.app

@Dr-Electron
Copy link
Collaborator Author

So now you could either use:
https://iota-wiki-98xis31i6-iota1.vercel.app/identity.rs/introduction/
or
https://iota-wiki-98xis31i6-iota1.vercel.app/identity.rs/0.6/introduction/

which doesn't work in the current wiki:
http://wiki.iota.org/identity.rs/0.6/introduction/

@Dr-Electron Dr-Electron marked this pull request as ready for review September 30, 2023 21:08
@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 3976914

✅ Preview: https://iota-wiki-3hkx9epe2-iota1.vercel.app

@jlvandenhout
Copy link
Contributor

We can do this later but: have you considered doing it the other way around? So just give every version a /<project>/<version> path and then point /<project> to a configured default version?

@Dr-Electron
Copy link
Collaborator Author

We can do this later but: have you considered doing it the other way around? So just give every version a /<project>/<version> path and then point /<project> to a configured default version?

I thought about it. But never went through the idea properly 🤔
Could make more sense. Let's revisit after we have versioning where we want it to be, where we have redirects for Shimmer and the first verion in the config for every network is the main version

@Dr-Electron Dr-Electron merged commit cccc0cc into main Oct 4, 2023
12 checks passed
@Dr-Electron Dr-Electron deleted the version-redirects branch October 4, 2023 10:47
@eike-hass
Copy link
Contributor

eike-hass commented Oct 4, 2023 •
edited
Loading

I thought about it. But never went through the idea properly 🤔
Could make more sense. Let's revisit after we have versioning where we want it to be, where we have redirects for Shimmer and the first verion in the config for every network is the main version

The result, or more accurately the deep-linking capabilities would be the same then, right?

@Dr-Electron
Copy link
Collaborator Author

I thought about it. But never went through the idea properly 🤔
Could make more sense. Let's revisit after we have versioning where we want it to be, where we have redirects for Shimmer and the first verion in the config for every network is the main version

The result, or more accurately the deep-linking capabilities would be the same then, right?

Yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlvandenhout jlvandenhout jlvandenhout approved these changes

@eike-hass eike-hass Awaiting requested review from eike-hass

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow "deep" links to main version of versioned project
3 participants
@Dr-Electron @jlvandenhout @eike-hass